search

flashbots / mev-boost

MEV-Boost allows Ethereum validators to source high-MEV blocks from a competitive builder marketplace
https://boost.flashbots.net
MIT License
1.17k stars 208 forks source link

server: refactor process*Payload functions #644

Closed MariusVanDerWijden closed 2 months ago

MariusVanDerWijden commented 5 months ago

This PR changes the way the process functions work. Since it is safe to call cancel() multiple times, and we only need one valid payload from the relays, I think its safe to stick the results in a channel and only query one of them

MariusVanDerWijden commented 5 months ago

Somethings wrong... am investigating

MariusVanDerWijden commented 2 months ago

Seems like the issue was the same as in https://github.com/flashbots/mev-boost/pull/650 Attestantio was broken

codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 77.41935% with 7 lines in your changes missing coverage. Please review.

Project coverage is 43.69%. Comparing base (74a8ecb) to head (c8ab903). Report is 1 commits behind head on develop.

Files Patch % Lines
server/service.go 77.41% 4 Missing and 3 partials :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #644 +/- ## =========================================== - Coverage 43.84% 43.69% -0.16% =========================================== Files 15 15 Lines 1608 1609 +1 =========================================== - Hits 705 703 -2 - Misses 847 849 +2 - Partials 56 57 +1 ``` | [Flag](https://app.codecov.io/gh/flashbots/mev-boost/pull/644/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/flashbots/mev-boost/pull/644/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `43.69% <77.41%> (-0.16%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.