search

flashbots / mev-relay-js

MIT License
106 stars 41 forks source link

add flashbots core version targeting #37

Closed thegostep closed 3 years ago

thegostep commented 3 years ago

To enable the new flashbots core rolling release patterns, we need to add a version field to the eth_sendBundle and eth_callBundle endpoints. If unspecified, the default version should be 'latest'. If a deprecated version is specified, an error should be thrown. If using a version which differs from 'latest' a warning should be issued.

jparyani commented 3 years ago

I'm not sure where to put this version. Should it be a param inside the json rpc bundle? Should it be an http header? It's probably easier to implement as a header on the server side, but I worry it's very hard for clients to add a header dynamically.

If it is a param, I'd argue we probably need to turn params into an object. The reason is, there's now many optional params, and it's very messy to have a list of optional params in an array.