search

flashbots / mev-share-node

GNU Affero General Public License v3.0
95 stars 12 forks source link

"special_logs" hint #39

Closed kaber2 closed 2 months ago

kaber2 commented 2 months ago

Trying to debug why I receive mutilated logs, I discovered the "special_logs" hint. This seems like a rather odd design choice. If the user decides to share logs, why would you override his decision and make them unusable?

Additionally, this seems futile. First of all, the list of special signatures is more or less random, handling some big protocols, not handling others. It is also missing things like Curve "ExchangeUnderlying". But most importantly, the Transfer events contain all the information about which swaps happened anyway. So this is just making life harder for no gain, being undocumented and against the explicit statement of the user to share his logs.

I'd suggest to remove this "feature".

kaber2 commented 2 months ago

I can see now that this only applies to transactions where the user did not explicitly select to share the logs. Closing.