search

flashbots / rbuilder

rbuilder is a blazingly fast, state of the art Ethereum MEV-Boost block builder written in Rust
Apache License 2.0
244 stars 48 forks source link

feat: Add BuiltBlockTracerError #21

Closed ghost closed 3 months ago

ghost commented 3 months ago

📝 Summary

💡 Motivation and Context

✅ I have completed the following steps:

ZanCorDX commented 3 months ago

Thanks for your interest in the rbuilder and being the first external contributor! Now about the code:

github-actions[bot] commented 3 months ago

Benchmark results for 770b05a

Report: https://flashbots-rbuilder-ci-stats.s3.us-east-2.amazonaws.com/benchmark/770b05a-a25f33b/report/index.html
Date (UTC) 2024-07-05T07:05:27+00:00
Commit 770b05ae295e308cbed634124a7c64e7ce9dfde7
Base SHA a25f33b44d80a9ea12ac5ea2e68e54a89ce092a8

Significant changes

Benchmark Mean Status
MEV-Boost SubmitBlock serialization/JSON encoding 10.74% Performance has degraded.
metachris commented 3 months ago

Don't mind the benchmark comment about degraded performance. It's a bit flaky, and should be fixed by https://github.com/flashbots/rbuilder/pull/15 which we intend to merge soon.

ghost commented 3 months ago

Don't mind the benchmark comment about degraded performance. It's a bit flaky, and should be fixed by #15 which we intend to merge soon.

Okay, I see.

ZanCorDX commented 3 months ago

Good work! Next time, try making separate PRs for things like lint/gitignore and "real" code changes. This time you get a free pass for being the first collaborator!