flashbots / suave-std

Collection of helpful smart contracts to build Suapps
The Unlicense
44 stars 13 forks source link

Make decodeSignature internal #103

Closed pistomat closed 1 month ago

pistomat commented 1 month ago

Using public or external function in a Solidity library forces the library to be externally deployed and linked instead of embedded. From a dev perspective this is super annoying and not that useful.

I don't see a reason why this single function should be public, more so because it is a simple pure function.