adding extra delay to give web3 providers more time to synch and load…

flashbots / web3-flashbots

Web3.py plugin for using Flashbots' bundle APIs

https://pypi.org/project/flashbots/

MIT License

405 stars 213 forks source link

adding extra delay to give web3 providers more time to synch and load… #63

Open mdigi14 opened 2 years ago

mdigi14 commented 2 years ago

Added an extra delay to the code that checks for bundle inclusion. I have encountered bugs where the TransactionNotFound error is raised even when my bundles land on chain.

This suggests that web3 providers sometimes update the value returned by 'w3.eth.block.number' before the 'w3.eth.get_transaction()' endpoint is aware of all transaction hashes from a recent block.

This may cause an issue where end-users send the same bundle twice because they do not receive proper confirmation.

odysseus0 commented 3 months ago

Yo this is actually an interesting idea. I am wondering if it will have unintended adverse side effects in some areas. WDYT?