flashcarts / flashcard-archive

An archive of all the firmwares for Nintendo DS flashcards
https://archive.flashcarts.net
285 stars 20 forks source link

Update to include Wood R4 with additional skins and latest official R4 firmware #14

Closed pomegrenade closed 1 year ago

pomegrenade commented 1 year ago

Added additional skins for Wood R4, such as the Acekard RPG, Zelda, GBATemp. Also added the latest english release for the official R4 firmware, purely for archival purposes and not for any recommended use.

lifehackerhansol commented 1 year ago

Hello, thank you for your PR.

For a few reasons, I'm going to have to NACK this change.

On the original R4 kernel: If it's not recommended for use, we should not add it. If we find a suitable updated kernel where possible (such as what we've been doing with BL2CK for a while now), then we should redirect users to using that and removing the older, non-working ones. The only exception to this rule is YSMenu, where we do not have the permission to add to this repo. So instead, we leave what's known to work on them, and if those work, move on to helping users install YSMenu instead.

On the extra themes: I explicitly only included one theme for each kernel where possible to save space on the repository. Skins can easily be found in other places such as GBAtemp, FileTrip on Wayback Machine, or even on our twlmenu-extras repo and as such there is no need to duplicate that here, instead only adding what was the default theme for each kernel and leaving it at that. (also, you only updated the original R4 one, but not the other Wood kernels...?)

I hope that is understandable.

pomegrenade commented 1 year ago

No problem, I added these more as a way to preserve them due to the archival nature of the project, as often sources may go down and such. As this repo is more of a resource to help users with their flashcarts, I understand why adding anything redundant is unnecessary.