Small fixes for NoteMod on for Isolation Offset

flashflashrevolution / rCubed

Official Flash Flash Revolution game engine.

https://www.flashflashrevolution.com

GNU Affero General Public License v3.0

31 stars 17 forks source link

Small fixes for NoteMod on for Isolation Offset #199

Closed Psycast closed 4 years ago

Psycast commented 4 years ago

Lower bound wasn't checked, causing a out-of-bounds null error.

Psycast commented 4 years ago

In transformNote(), is there a chance notes.length is 0? If so, then the notes array access in the modReverse if block might be out-of-bounds.

I don't believe there's a chance no.

Side Note: The initial bound check I changed was actually wrong anyway as I misread how options.isolationOffset was being set and adding a - 1 when I didn't need to.