flashflashrevolution / rCubed

Official Flash Flash Revolution game engine.
https://www.flashflashrevolution.com
GNU Affero General Public License v3.0
31 stars 17 forks source link

Rewrite Noteskins to use Embedded Data instead of network #209

Closed Psycast closed 4 years ago

Psycast commented 4 years ago

Loading the noteskin SWF data from the server used to be needed to provided easier ways for noteskins to be added without requiring a new engine build.

Since the inclusion of Custom Noteskins, no new noteskins have been added to the network noteskins for many years and just adds to the engine load time.

This rewrite embeds all current noteskin data into the game to remove network loading, optimizes how it's loaded, and add documentation and general code cleanup to the overall class.

This also changes how noteskins are stored to remove the need for consent and slow null checks and fallbacks by filling any possible gaps in the noteskin data during the loading and verifying stage.