flashflashrevolution / rCubed

Official Flash Flash Revolution game engine.
https://www.flashflashrevolution.com
GNU Affero General Public License v3.0
31 stars 17 forks source link

Fix/typed entities #271

Closed mat100payette closed 3 years ago

mat100payette commented 3 years ago

This massive PR introduces typed entities to replace the majority of dynamic objects that were used, such as User, Room, Gameplay, SongInfo, etc.

The changes should most definitely make coding much simpler for new/beginner devs who aren't very familiar with the code already. Easy object navigation and refactoring in the IDE is now possible for most of the MP code, and the whole middle layer for user and room management (from SFS) was removed to allow for full control over the received events from the server. There is still some small coupling with the SFS code due to the types being restrained to User and Room, but that should be fine since they represent the core of MP data.

Hoping this helps at least until the whole engine is scrapped and replaced by modern stuff. :)