search

flashingpumpkin / django-socialregistration

Combining OpenID, OAuth and FacebookConnect signup in one application
MIT License
610 stars 146 forks source link

Problem with google OpenId - escaped namespace in OpenId.isValid() #68

Open kozak opened 13 years ago

kozak commented 13 years ago

the fix is to unquote the get arguments you get from the request:

def complete(self): args = dict(self.request.GET.items()) args_unquoted = {} for key, value in args.iteritems(): args_unquoted[key] = urllib2.unquote(value) self.result = self.consumer.complete( args_unquoted, 'http%s://%s%s' % (_https(), Site.objects.get_current(), self.request.path) )

flashingpumpkin commented 13 years ago

Not sure what's going on. I just tested it out with OpenID + Google without having to tamper with any quoting.

kozak commented 13 years ago

Will have to investigate when I get some time so I can get you a good test case

flashingpumpkin commented 13 years ago

Is this still an issue?