Fix flaking LexiconFreeSeq2SeqDecoderTest

flashlight / text

Text utilities, including beam search decoding, tokenizing, and more, built for use in Flashlight.

MIT License

64 stars 14 forks source link

Fix flaking LexiconFreeSeq2SeqDecoderTest #39

Closed jacobkahn closed 1 year ago

jacobkahn commented 1 year ago

Summary

Because multiple paths had identical scores for token idx 1 in the test, different compiler implementations of std::sort return different results (thanks, MSVC!).

Test plan: CI/rebase Windows tests

Checklist

[x] Test coverage
[x] Tests pass
[x] Code formatted
[x] Rebased on latest matter
[x] Code documented

facebook-github-bot commented 1 year ago

@jacobkahn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@jacobkahn merged this pull request in flashlight/text@7934b1bda5971b8c5f4faffe7fa29189e17b83e5.