search

flashlight / text

Text utilities, including beam search decoding, tokenizing, and more, built for use in Flashlight.
MIT License
64 stars 15 forks source link

Update PyBind to v2.10.3 for Python 3.11 support #47

Closed jacobkahn closed 1 year ago

jacobkahn commented 1 year ago

See title. Library artifacts in wheel build had None appended as their dylib suffix when built with a pybind version that didn't support Python 3.11. Fix this upstream.

Example of wheel building issue: https://github.com/flashlight/text/actions/runs/4212845603/jobs/7312722284

Test plan: CI + cibw

facebook-github-bot commented 1 year ago

@jacobkahn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@jacobkahn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@jacobkahn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@jacobkahn merged this pull request in flashlight/text@1c7af7efd1023a7f3ea74144b4617d0b61c3e6bf.