Ensure CMake uses the correct executable per cibuildwheel

flashlight / text

Text utilities, including beam search decoding, tokenizing, and more, built for use in Flashlight.

MIT License

64 stars 14 forks source link

Ensure CMake uses the correct executable per cibuildwheel #48

Closed jacobkahn closed 1 year ago

jacobkahn commented 1 year ago

See title. Using FindPython3 in CMake >= 3.16 requires using PYTHON3_EXECUTABLE as the relevant flag specifying the interpreter path. This ensures that headers and modules are found in the proper subtree by CMake such that bindings are linked against the correct version of Python. Current Wheel builds link against totally spurious versions.

Test plan: CI + CIBW, ensuring that the correct CIBW version of Python is what CMake finds at wheel build time.

facebook-github-bot commented 1 year ago

@jacobkahn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@jacobkahn merged this pull request in flashlight/text@07e56730cd0abce37aff1693bf43d7b8689eb5b9.