Remove superfluous add_subdirectory from Buildpybind11

flashlight / text

Text utilities, including beam search decoding, tokenizing, and more, built for use in Flashlight.

MIT License

64 stars 14 forks source link

Remove superfluous add_subdirectory from Buildpybind11 #50

Closed jacobkahn closed 1 year ago

jacobkahn commented 1 year ago

Summary: CMake FetchContent_MakeAvailable already adds the target project's source and binary dirs and makes those targets available to the rest of the build -- this line as it stands does nothing and is just error prone

Differential Revision: D43447919

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D43447919

facebook-github-bot commented 1 year ago

This pull request has been merged in flashlight/text@ddfa5eee4d1a23217dfa66bcadef31741d957d06.