Closed jacobkahn closed 1 year ago
@jacobkahn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@jacobkahn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@jacobkahn merged this pull request in flashlight/text@5758306352993c21bb50ebbc5bd65c77d78a66fc.
Summary
Change howNever installFindkenlm.cmake
is installed -- only install if it it was required to find KenLM in the first place (i.e. the KenLMCONFIG
) didn't exist.Findkenlm.cmake
, since it relies on a deprecated install flow. Only use it if building Python bindings which requirelibkenlm.so
(and the Windows implib) from site-packages.This also changes the exported CMake config to only use the CMake config version when finding KenLM for downstream project linking.
Checklist
Test plan: CI, local tests