flashlight / wav2letter

Facebook AI Research's Automatic Speech Recognition Toolkit
https://github.com/facebookresearch/wav2letter/wiki
Other
6.35k stars 1.02k forks source link

Fixed bug causing "Unknown speaker!" in ami recipe #977

Open alkazap opened 3 years ago

alkazap commented 3 years ago

Original Issue: https://github.com/flashlight/wav2letter/issues/976

closes #[976]

Summary

python prepare.py fails with AssertionError: Unknown speaker! FEE005

Test Plan (required)

Assertion error comes from utils.py line 117 assert speaker in speakers, f"Unknown speaker! {speaker}"

Judging by the assertion and line 119 speaker = speakers[speaker], the script expects speakers to be a dictionary, however, as we can see on line 111 speakers = {(speaker.id, speaker) for speaker in speakers}, speakers is a set of tuples.

Line 111 should be speakers = { speaker.id : speaker for speaker in speakers }, then the script works as intended.

facebook-github-bot commented 3 years ago

Hi @alkazap!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 3 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!