search

flashmob / go-guerrilla

Mini SMTP server written in golang
MIT License
2.78k stars 366 forks source link

200 OK response on NOOP command #140

Open mibes opened 5 years ago

mibes commented 5 years ago

At the moment go-guerrilla returns a 200 OK upon receiving a NOOP command. Our client expects a 250 OK. The latter seems to be in line with the RFC.

We fixed this by making the following code change in enhanced.go:

        Canned.SuccessNoopCmd = &Response{
        EnhancedCode: OtherOrUndefinedProtocolStatus,
        BasicCode:    250,
        Class:        ClassSuccess,
    }

If this does not break anything else, you may consider this change for an upcoming release.

flashmob commented 5 years ago

Thanks, will update it soon.