panic: send on closed channel - Githubissues

flashmob / go-guerrilla

Mini SMTP server written in golang

MIT License

2.76k stars 361 forks source link

panic: send on closed channel #214

Open orestonce opened 3 years ago

orestonce commented 3 years ago

startWG.Done does not ensure that s.Start() returns to completion, nor does it ensure that the writing of errs <- err is completed. Calling close(errs) directly after startWg.Wait() may close a channel being written to, resulting in panic。

https://github.com/flashmob/go-guerrilla/blob/aa54b3ac4a0b4b34232fd29239422d024ad9395e/guerrilla.go#L484

panic may position: https://github.com/flashmob/go-guerrilla/blob/aa54b3ac4a0b4b34232fd29239422d024ad9395e/guerrilla.go#L476 https://github.com/flashmob/go-guerrilla/blob/aa54b3ac4a0b4b34232fd29239422d024ad9395e/guerrilla.go#L484