search

flashmob / go-guerrilla

Mini SMTP server written in golang
MIT License
2.79k stars 366 forks source link

case-insensitive import collision in logrus #87

Closed ganglio closed 6 years ago

ganglio commented 7 years ago

When importing as a package in an application already using logrus upon compilation it returns the following error:

src/github.com/flashmob/go-guerrilla/log/hook.go:5:2: case-insensitive import collision: "github.com/Sirupsen/logrus" and "github.com/sirupsen/logrus"

The current logrus readme reports the change in case for the github user asking the update of the package name whenever used to match the new lowercase one.

Could you please update?

flashmob commented 7 years ago

Hi,

Thanks for reporting.

The go get way to download the dependencies may be broken, especially when the dependencies change, such as the case with logrus. So perhaps you may want to try using the glide tool instead. Glide currently locks logrus to the following commit hash: ba1b36c82c5e05c4f912a88eab0dcd91a171688f

Although it would be good to update to the latest logrus soon, so let this issue be a placeholder for the update.

ganglio commented 7 years ago

If you want I can fork it and do the case switching. I will need to do it anyway as I really need the package (it’s the most comprehensive and versatile SMTP server as a library out there 😀 ). I could do a pull request if you like.

flashmob commented 7 years ago

yes please - would be very welcome. Would this also update the glide dependency?

ganglio commented 7 years ago

Sure. Why not 😀 Not sure if I can make it during the weekend, tho. Monday more likely.