Reducing the dependency footprint

danielwhite commented 6 years ago

Currently I've been building a prototype to use this to provide an SMTP adapter to an internal system and I'm really loving the changes to provide this as a library.

The problem I'm facing with gaining more acceptance are the dependencies that are unrelated to the primary problem.

Is there is any appetite for contributions to reduce this footprint?

Specifically:

[x] MySQL: provide a compatible interface or use a separate repository (like maildir-processor)
[ ] Redis: provide a compatible interface or use a separate repository (like maildir-processor)
[ ] logrus: provide a compatible interface to logrus, but only directly reference in cmd/

From what I can tell, cmd/guerrillad is excluded from dependency resolution (at least by golang/dep), so it definitely can continue to import the above packages to provide a fully featured default server.

flashmob commented 6 years ago

Hello @danielwhite

Sorry for the long break, but are you still around? If so, could you have a few minutes to take a look at this PR and tell me if that's what you meant?

https://github.com/flashmob/go-guerrilla/pull/114

danielwhite commented 1 year ago

Hi @flashmob, somehow got lost along the way. This looks pretty close. Thanks!

flashmob commented 1 year ago

yeah, life got in the way a bit. Very close though, it would be interesting to see how it performs. Perhaps one day!

On Fri, 16 June 2023, 16:30 Daniel White, @.***> wrote:

Hi @flashmob https://github.com/flashmob, somehow got lost along the way. This looks pretty close. Thanks!

— Reply to this email directly, view it on GitHub https://github.com/flashmob/go-guerrilla/issues/94#issuecomment-1594240870, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE6MP5NV2VZ6IYVTLW5FITXLQDQTANCNFSM4EGG2LCQ . You are receiving this because you were mentioned.Message ID: @.***>

flashmob / go-guerrilla

Reducing the dependency footprint #94