reserved identifier violation

flashxio / FlashX

FlashX is a collection of big data analytics tools that perform data analytics in the form of graphs and matrices.

http://flashx.io/

Apache License 2.0

231 stars 53 forks source link

reserved identifier violation #95

Open elfring opened 9 years ago

elfring commented 9 years ago

I would like to point out that identifiers like "__CACHE_H__" and "__MY_PARAMETERS_H__" do not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

jovo commented 9 years ago

@elfring do you have a particular style guide in mind?

elfring commented 9 years ago

How do you think about to make your include guards not only standard-compliant but also really unique by appending a kind of UUID?

zheng-da commented 9 years ago

I don't know how UUID works, but I guess I can adopt the boost style or the Google style. Basically, it'll look like this: <PROJECT>_<PATH>_<FILE>_H_