search

flask-dashboard / Flask-MonitoringDashboard

Automatically monitor the evolving performance of Flask/Python web services.
http://flask-monitoringdashboard.readthedocs.io/
MIT License
776 stars 160 forks source link

Jinja2 version mismatch with flask2.0 #398

Open kvalv opened 3 years ago

kvalv commented 3 years ago

Hi,

So for flask2.0 requirements, the minimum required version for Jinja is 3.0, whereas the flask monitoring dashboard requirements are pinned to 2.11.1. This is unfortunate as it means it's not possible to create a consistent set of requirements for flask 2.0 with flask monitoring dashboard.

Is it possible to remove this pinned requirement?

As a sidenote, I can see that it has already been removed on the development branch, and I ideally want a new release that I can use instead of having to specify a commit / branch that works with flask 2.0. :small_airplane:

To reproduce:

cd /tmp
mkdir foo && cd foo
python3.7 -m venv myvenv
. ./.myvenv/bin/activate
pip install pip-tools
echo "flask>=2.0\nflask_monitoringcashboard" > requirements.in
pip-compile  # this fails
Gresliebear commented 3 years ago

I am gettting tthe same issue

flask-monitoringdashboard 3.1.0 has requirement jinja2==2.11.1, but you'll have jinja2 3.0.1 which is incompatible.

mircealungu commented 3 years ago

If you look in the requirements.txt you'll see that the jinja2 is pinned to 2.11.1 in order to prevent breaking python 3.6... Does any one of you use 3.6 to confirm that the problem does not exist with Jinja 3.0.1? Thanks!

kvalv commented 3 years ago

Hey, unfortunately I do not use 3.6 so I am not able to confirm it. I could try take a look in python3.6 to see whether that's the case, but I don't really know what I'm looking for

mircealungu commented 3 years ago

Hi @kvalv !

Don't worry, the bug is fixed in the upcoming release: https://github.com/flask-dashboard/Flask-MonitoringDashboard/pull/399

There is only one issue that I'd still like to fix before that release: Issue https://github.com/flask-dashboard/Flask-MonitoringDashboard/issues/400. I just don't have the time to work on it yet. Do you know Angular? :)

kvalv commented 3 years ago

Oh, that is nice to hear!

Unfortunately, I have very little knowledge of angular :stuck_out_tongue:

tddough98 commented 3 years ago

Any update on the 3.1.1 release in #399? I'm finding myself needing to use Flask 2 and FMD is the only dependency blocking me

mircealungu commented 3 years ago

Hi @tddough98 - thanks for the reminder! we'll try to release asap!

tddough98 commented 3 years ago

Is there anything blocking the 3.1.1 release? I see that there is one issue #400 mentioned above but it looks like the bug is present in 3.1.0 too. Can the fix for #400 be pushed to 3.1.2 so that improvements from 3.1.1 can make it out?

mircealungu commented 3 years ago

thanks @tddough98 for the reminder. I'll try to create the release in this weekend!

HrisyToteva commented 1 year ago

Hi @kvalv thank you for bringing up this issue and taking the time to contribute to the Flask-MonitoringDashboard project.

As part of my school project, my team is conducting a usability research study to improve the dashboard. I noticed your experience with the app and thought it would be valuable to gather more insights from you.

Would you be open to receiving a few questions about your experience with Flask-MonitoringDashboard? It won't take more than 20 minutes to answer them. Your feedback will play a vital role in enhancing the app's functionality and addressing any existing limitations.

If you're interested, please let me know, and I will send you the questions. Your involvement would be highly valuable and greatly appreciated.