search

flask-dashboard / Flask-MonitoringDashboard

Automatically monitor the evolving performance of Flask/Python web services.
http://flask-monitoringdashboard.readthedocs.io/
MIT License
781 stars 160 forks source link

Detecting that an Endpoint has been renamed #55

Open mircealungu opened 6 years ago

mircealungu commented 6 years ago

It would be nice if the history of an endpoint that was renamed would not be lost, but rather, the rename would be detected and taken into account in the UI and in the analysis.

I wonder how difficult this would be.

Two challenges I see:

Finally, the easy solution would be to let the user add some extra configuration for this.

FlyingBird95 commented 6 years ago

Maybe, this is possible using the git-data, as git keeps track of the changes

vandriko commented 6 years ago

The short version: rename = delete + add (as pointed above). You can however try to detect it by identifying the pattern of events in the log, but it then it needs to be combined with tracing to the source code = headache in case more than one endpoints are renamed in one commit. Better to allow the user to pin deleted endpoints to currently monitored endpoints in the main configuration screen (e.g. through a dropbox showing "orphan" endpoints from the DB that do not correspond to functions in the code any more) and aggregate the data for the visualization. How difficult would that be?

On Wed, Feb 21, 2018 at 7:01 PM, Patrick Vogel notifications@github.com wrote:

Maybe, this is possible using the git-data, as git keeps track of the changes

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/flask-dashboard/Flask-Monitoring-Dashboard/issues/55#issuecomment-367414975, or mute the thread https://github.com/notifications/unsubscribe-auth/AJkLZDvpgRTaG_x5xpKjpkPILZDUHGLIks5tXFnmgaJpZM4SNwEz .

mircealungu commented 6 years ago

I very much like the idea with the "orphan" endpoints. The dev can then confirm if an endpoint is deleted vs. an endpoint being the predecessor of another one. It can even provide suggestions among the endpoints that were introduced after the orphan disappeared from the code!