search

flask-extensions / Flask-GoogleMaps

Easy way to add GoogleMaps to Flask applications. maintainer: @getcake
https://flask-googlemaps.com
MIT License
644 stars 195 forks source link

WIP: [RFC]: Bring Flask-GoogleMaps up to date with latest dependencies #159

Open argysamo opened 5 months ago

argysamo commented 5 months ago

Fixes #158

argysamo commented 5 months ago

hey @getcake , I started working a feature branch to update Flask Google-Maps to use the latest Google Maps API and make it work with Flask 3.X.X. Regarding the former, there's much more flexibility with creating markers. The colour of those can be easily customized via a PinElement. One could use an html img (or even a div) as a marker. I have (kind of) implemented the support for an img element.

Making all these changes, it's kind of difficult to maintain backwards compatibility. This mainly regards, the way a user can define markers. More specifically, I wasn't able to think of way to maintain the icon notion with the new API, and thus I removed it.

Along with the aforementioned updates, I am refactoring a bit the code introducing unit tests.

Do you have any concerns? Do you think that these changes would be of value?

Cheers, Argyris

argysamo commented 5 months ago

maybe @rochacbruno ?

argysamo commented 5 months ago

maybe @cuducos ?

argysamo commented 5 months ago

@marcuxyz ?

rochacbruno commented 5 months ago

LGTM @argysamo regarding the icon, as long as there is an alternative to add icons with the new markers API I am ok on doing a major release removing the icons API.

rochacbruno commented 5 months ago

The example site build is failing because image is outdated on Netlify, it is running on @Riverfount account, I think what is needed is to check netlify panel and opt-in for an image update I guess.

Riverfount commented 5 months ago

The example site build is failing because image is outdated on Netlify, it is running on @Riverfount account, I think what is needed is to check netlify panel and opt-in for an image update I guess.

I can move it to another account, but which account?

Riverfount commented 5 months ago

The example site build is failing because image is outdated on Netlify, it is running on @Riverfount account, I think what is needed is to check netlify panel and opt-in for an image update I guess.

I can move it to another account, but which account?

Sorry guys I can't move the site to another account on Netlify, but I can continue to maintain it in my account!

argysamo commented 5 months ago

thanks so much for the feedback and the actions. Great to hear that you are interested in the new Markers API. I will continue with code change and testing, update the documentation and ping you here once the PR is ready to be reviewed!

marcuxyz commented 4 months ago

it's very nice @argysamo . I believe that things as:

Can be separated in another pr.

👏🏾 👏🏾 👏🏾 👏🏾 👏🏾

argysamo commented 4 months ago

Hey @marcuxyz , Makes total sense. I will cherry pick right now the ci changes and create a new PR. Thanks!

rochacbruno commented 4 months ago

needs a rebase

Riverfount commented 4 months ago

Hi, guys if you need some help and just me I can do it, mark me on the comment because I see them more quickly.

argysamo commented 3 months ago

Hello all, I didn't make any progress for the last couple of weeks. I started working again on the documentation now, and will verify that the new changes don't break existing functionality. I will update you when changes are ready for review.

Cheers, Argyris