Better way of handling markers in JS

flask-extensions / Flask-GoogleMaps

Easy way to add GoogleMaps to Flask applications. maintainer: @getcake

https://flask-googlemaps.com

MIT License

647 stars 196 forks source link

Better way of handling markers in JS #25

Closed RubenRocha closed 8 years ago

RubenRocha commented 8 years ago

As I mentioned in the other PR I did, I think this would better suited as we won't have tons of unnecessary variables from doing it with the templating system, instead we do it with javascript.

Before Instead of 25 of those variables + addListeners, we have this: After

rochacbruno commented 8 years ago

Merging your latest PR #24 introduced conflicts with this PR. Can you please adjust this PR? it will be very welcome to improve the JS code!

Thanks

RubenRocha commented 8 years ago

@rochacbruno I think I've fixed the conflict

rochacbruno commented 8 years ago

@RubenRocha thanks a lot for improvements!

BTW: there is still a lot of ideas to get from #17