flask-extensions / Flask-GoogleMaps

Easy way to add GoogleMaps to Flask applications. maintainer: @getcake
https://flask-googlemaps.com
MIT License
644 stars 195 forks source link

Bad setup.py in 0.2.5 #59

Closed wontonst closed 4 years ago

wontonst commented 7 years ago

0.2.4 is fine, regression occurs at 0.2.5

Repro is easy:

pip install -v flask-googlemaps

Tidbit you're interested in is

Installing collected packages: Werkzeug, MarkupSafe, Jinja2, click, itsdangerous, flask, flask-googlemaps

  Compiling /private/var/folders/2h/0dr8jftd1916yq_lp40__wzh0000gn/T/pip-build-avapA_/Jinja2/jinja2/asyncfilters.py ...
    File "/private/var/folders/2h/0dr8jftd1916yq_lp40__wzh0000gn/T/pip-build-avapA_/Jinja2/jinja2/asyncfilters.py", line 7
      async def auto_to_seq(value):
              ^
  SyntaxError: invalid syntax

  Compiling /private/var/folders/2h/0dr8jftd1916yq_lp40__wzh0000gn/T/pip-build-avapA_/Jinja2/jinja2/asyncsupport.py ...
    File "/private/var/folders/2h/0dr8jftd1916yq_lp40__wzh0000gn/T/pip-build-avapA_/Jinja2/jinja2/asyncsupport.py", line 22
      async def concat_async(async_gen):
              ^
  SyntaxError: invalid syntax

Impact to user is when you do pip freeze it won't show Flask-GoogleMaps==0.2.5

The error is coming from Jinja but pip install Flask still causes Flask to show up in pip freeze, so something is wrong with the setup.py

mattdaviscodes commented 7 years ago

Thanks @wontonst! @rochacbruno, this is what I was talking about in my comment on PR #56.

For reference, here's the stack overflow question: https://stackoverflow.com/questions/46105730/why-doesnt-pip-installed-package-show-up-in-pip-freeze

vit0r commented 4 years ago

@wontonst the setup.py was replaced by pyproject.toml

Poetry Python packaging and dependency management

Riverfount commented 4 years ago

Please use the new release of the project! Thanks!