flatcar / Flatcar

Flatcar project repository for issue tracking, project documentation, etc.
https://www.flatcar.org/
Apache License 2.0
774 stars 32 forks source link

plume: select partitions via cmd flag #242

Closed mazzy89 closed 4 years ago

mazzy89 commented 4 years ago

Current situation

My understanding currently is that mantle publish images to all the awsPartitions specified.

Impact

We, at Giant Swarm, need to publish Flatcar images to AWS China. Introducing the AWS China partition would empower mantle to publish to China however it would cause to run operations also in AWS Global region.

Ideal future situation

Select by the cmd line the AWS Partitions so the publishing will be executed only to AWS China

Implementation options

Change https://github.com/flatcar-linux/mantle/blob/flatcar-master/cmd/plume/containerlinux.go#L40 to map[string]awsPartitions{} and have AWS Global region with a key default and China china.

From the cmd line will be possible to select the AWS Partition i.e.

plume pre-release --partition=china
pothos commented 4 years ago

Yes, thanks for the suggestion. That would work and allow to publish to multiple regions in China. The other option is to use ore aws upload which uploads to a single region. We just need to ensure first that it does the same as plume in terms of metadata etc.

mazzy89 commented 4 years ago

I've just realized that ore accomplish the same task. Last decision to you @pothos

pothos commented 4 years ago

Closing as https://github.com/flatcar-linux/mantle/pull/83 is merged.