Closed chewi closed 1 month ago
@sayanchowdhury / @tormath1 do we use this script?
Good question. I think most of the package diff is now handled from bash script: https://github.com/flatcar/flatcar-build-scripts/blob/6495dd7bf80b6ec7e5646cf06a50eadb6dea996c/package-diff (see: https://github.com/flatcar/scripts/blob/29f7c259bd77173ae91b4e65cb8dd4ef424d5482/ci-automation/image_changes.sh#L310)
Seems likely, given that I can't see coreos-overlay-diff.py
referenced anywhere across the org. @krnowak, please could confirm. If it's redundant, I'll just close this and drop it in #160.
@chewi: I don't think I have ever used the script. Feel free to kill it.
Description
This script was written against sh 1.x. There were some significant breaking changes in 2.x, notably the way pipes are constructed and the type returned.
Impact
Environment and steps to reproduce
Expected behavior
It outputs information about which commits to pick.
Additional information
I would fix this now, but I imagine it's still used in places that don't have sh 2.x. We could support both, but quite a few lines would need to be duplicated. The syntax is quite different.