search

flathub-infra / backend

https://github.com/flathub/website/
Apache License 2.0
26 stars 9 forks source link

Some apps have missing icons, probably due to icon type="remote" #24

Closed jgarciao closed 3 years ago

jgarciao commented 3 years ago

If you go to https://flathub.org/apps/category/All you'll see some apps with missing icons.

For example: https://flathub.org/apps/details/com.anydesk.Anydesk https://flathub.org/apps/details/com.github.taiko2k.avvie https://flathub.org/apps/details/org.bluej.BlueJ https://flathub.org/apps/details/org.claws_mail.Claws-Mail https://flathub.org/apps/details/com.sigmyne.crush https://flathub.org/apps/details/com.discordapp.Discord https://flathub.org/apps/details/org.small_tech.Gnomit https://flathub.org/apps/details/com.github.utsushi.Utsushi https://flathub.org/apps/details/com.sublimetext.three

I think the problem is that some of this apps (or all) have in the appstream a mix of icon type remote and cached.

For example, sublime text:

    <icon type="remote">https://raw.githubusercontent.com/flathub/com.sublimetext.three/master/com.sublimetext.three-128.png</icon>
    <icon type="remote">https://raw.githubusercontent.com/flathub/com.sublimetext.three/master/com.sublimetext.three-64.png</icon>
    <icon type="cached" height="128" width="128">com.sublimetext.three.png</icon>
    <icon type="cached" height="64" width="64">com.sublimetext.three.png</icon>

https://flathub.org/apps/details/com.sublimetext.three

This is what the backend api returns: https://flathub.org/api/v1/apps/com.sublimetext.three

"iconDesktopUrl":"https://dl.flathub.org/repo/appstream/x86_64/icons/128x128/https://raw.githubusercontent.com/flathub/com.sublimetext.three/master/com.sublimetext.three-128.png",
"iconMobileUrl":"https://dl.flathub.org/repo/appstream/x86_64/icons/128x128/https://raw.githubusercontent.com/flathub/com.sublimetext.three/master/com.sublimetext.three-128.png"

Its possible that the backend is hardcoding https://dl.flathub.org/repo/appstream/x86_64/icons/128x128 for all icons?

barthalion commented 3 years ago

This was fixed with https://github.com/flathub/backend/pull/23.

jgarciao commented 3 years ago

Thanks!

El dc., 30 de des. 2020, 10:58, Bartłomiej Piotrowski < notifications@github.com> va escriure:

Closed #24 https://github.com/flathub/backend/issues/24.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/flathub/backend/issues/24#event-4156802530, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAQKTTYWRAJGZQAMRKJFDLSXL2TJANCNFSM4VM7A3KQ .