search

flathub-infra / flatpak-builder-lint

A linter for flatpak-builder manifests
MIT License
50 stars 133 forks source link

metainfo: Add a check for icon key and type #277

Closed bbhtt closed 8 months ago

bbhtt commented 9 months ago

For desktop applications. Shows error if there is no icon key present or icon key has no type or type remote.

Closes https://github.com/flathub-infra/flatpak-builder-lint/issues/83

For desktop applications only. Shows an error if there is no icon key present or icon key has no type or a icon key with type remote has icon not mirrored to https://dl.flathub.org/media/

bbhtt commented 9 months ago

Actually looks like, there's currently no issue with remote icons?

https://flathub.org/apps/app.moosync.moosync, https://flathub.org/apps/org.claws_mail.Claws-Mail etc. are using it and seems to be fine.

So I guess I can drop that check

barthalion commented 8 months ago

No, this is right. We want to block maintainers from using remote icons.