Closed bbhtt closed 8 months ago
I'm doing a PR to disable the check for now.
Ran into this building https://github.com/flathub/com.github.shonumi.gbe-plus/, which would complain about appstream-screenshot-missing-caption
even though I just added captions.
Locally, it doesn't complain about it:
$ flatpak run --command=flatpak-builder-lint org.flatpak.Builder builddir _build/
{
"errors": [
"appid-uses-code-hosting-domain"
],
"warnings": [
"finish-args-redundant-device-all"
]
}
Please consult the documentation at https://docs.flathub.org/docs/for-app-authors/linter
Yea that's what confused me too. Clearly, something is going wrong on the server, but I don't have the power to debug that.
Solved by porting to libappstream, will re-enable the check once more apps get rebuilt and composes their metadata with libappstream
For some reason Flathub, server side is stripping out captions from appstream catalogue data. The same is not reproducible when building locally using the exact same commands and
org.flatpak.Builder
The caption check should be re-enabled once the catalogue data has captions, otherwise the check has no meaning
See also https://github.com/flathub-infra/website/issues/48
https://hub.flathub.org/repo/appstream/x86_64/appstream.xml.gz:
shows only 3