search

flathub-infra / flatpak-builder-lint

A linter for flatpak-builder manifests
MIT License
49 stars 123 forks source link

exceptions: Add com.nextcloud.desktopclient.nextcloud #282

Closed tintou closed 7 months ago

tintou commented 7 months ago

The desktop file contains the "org.freedesktop.CloudProviders" group defined in "Implements" which is allowed by the spec.

A fix to the desktop file validator has been provided in https://gitlab.freedesktop.org/xdg/desktop-file-utils/-/merge_requests/21

bbhtt commented 7 months ago

LGTM, I'll try to add your patch in freedesktop sdk once it is merged given desktop-file-utils doesn't release often.

Hopefully then we can remove this exception, once that reaches Flathub

bbhtt commented 7 months ago

Hey @tintou was wondering if you want to contribute the patch to https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/blob/master/elements/components/desktop-file-utils.bst ?

It's adding the patchfile in patches/desktop-file-utils and adding a kind: patch, path: patches/desktop-file-utils/file.patch to the manifest there.

tintou commented 7 months ago

I will provide a patch once the MR is merged upstream as I want it to be validated before it being included :wink:

bbhtt commented 7 months ago

Sure thanks!