finish-args: redundant-device-all should not trigger when shm is present

flathub-infra / flatpak-builder-lint

A linter for flatpak-builder manifests

MIT License

48 stars 115 forks source link

finish-args: redundant-device-all should not trigger when shm is present #333

Closed bbhtt closed 3 months ago

bbhtt commented 4 months ago

all does not cover shm

man flatpak-metadata

/dev/shm (which is separately specified)

Seperate the tests to that affect too

hfiguiere commented 4 months ago

ideally no one needs shm. it was added with the belief it would solve JACK support, but then it turned out that JACK client and server (that use shm as a communication layer) must match. So it became pointless quickly.

hfiguiere commented 4 months ago

LGTM though

bbhtt commented 4 months ago

Yea still want to consider the case in the code.