search

flathub-infra / flatpak-builder-lint

A linter for flatpak-builder manifests
MIT License
50 stars 127 forks source link

modules: Disallow git branches in modules even if commit is present #346

Closed bbhtt closed 5 months ago

bbhtt commented 6 months ago

It is only allowed when the branch value is itself a commit hash.

Only branch with an actual branch name is non-reproducible, a branch and a commit means build fails whenever they mismatch.

Fix and seperate tests to that effect.

Closes https://github.com/flathub-infra/flatpak-builder-lint/issues/345

bbhtt commented 6 months ago

This is a breaking change for manifests using branch: branch_name and commit: commit_hash we need to notify as such