appstream: Require that appstream IDs match $FLATPAK_ID

flathub-infra / flatpak-builder-lint

A linter for flatpak-builder manifests

MIT License

48 stars 115 forks source link

Closed bbhtt closed 3 months ago

bbhtt commented 3 months ago

For historical reasons flatpak-builder passes `$FLATPAK_ID.desktop as a valid component ID to appstreamcli. This mismatch creates issues like the one described in https://github.com/flatpak/flatpak/pull/5752 and https://github.com/flathub/flathub/issues/4222

So require that both match and avoid new submissions leaking in with a mismatch.

bbhtt commented 3 months ago

This is a breaking change, we need to put exceptions for everything listed in https://github.com/flathub/flathub/issues/4222#issuecomment-2020140606

bbhtt commented 3 months ago

Should be ready now