search

flathub-infra / flatpak-builder-lint

A linter for flatpak-builder manifests
MIT License
50 stars 126 forks source link

Add exceptions for dev.bsnes.bsnes #400

Closed ghisvail closed 2 months ago

bbhtt commented 4 months ago

This should not be needed, if you are on Wayland the desktop theme and colour scheme is communicated to the sandbox via portals.

On X11 it is done by xsettings daemons.

ghisvail commented 4 months ago

I know. Sadly, the app uses a rather non-standard way of composing its GTK-based frontend.

They are not using portals, and they don't have the necessary skillset to make a proper refactoring to modern standards. It's basically a GTK-2 app with the bare minimal pieces of improvement to make it work with GTK-3.

bbhtt commented 4 months ago

It doesn't need to use portals, the values are communicated regardless of them supporting portals or not. Just the system need to be running the portals.

bbhtt commented 2 months ago

It doesn't need to use portals,

Actually I was thinking about a different theme option when I said this. The app or the toolkit indeed needs to read the values from settings portal or xsettings daemon.

I'll edit the reason and merge this.