search

flathub-infra / flatpak-builder-lint

A linter for flatpak-builder manifests
MIT License
46 stars 113 forks source link

exceptions: Add Subsurface to branch exception #401

Closed Alexander-Wilms closed 1 week ago

Alexander-Wilms commented 1 month ago

They use a custom updater via Github Workflow to update once per day as upstream creates builds on each commit.

After a few years of doing release builds not on GitHub, we have come full circle, but in a different way. We now do "nightly" builds (they actually happen when our main branch changes) and post them in a separate nightly build repo

Cf.

https://github.com/subsurface/subsurface/releases/tag/v4.9.4

and

https://subsurface-divelog.org/current-release/?lang=en

Also, unit tests are run after every Flathub build and prevent merging an update if they fail:

https://github.com/flathub/org.subsurface_divelog.Subsurface/blob/master/org.subsurface_divelog.Subsurface.yaml#L226

Regarding buildbot usage: The build only takes 10 min and I can just set the Actions workflow to be triggered once a week

image

bbhtt commented 1 month ago

Doing consistent daily builds is not sustainable for Flathub. If more and more applications come and request these I'd rather revoke all the existing exceptions than make an exception for some.

I'd be comfortable with it if it is biweekly or weekly at the very least.

Alexander-Wilms commented 1 month ago

Yes, weekly is fine.

bbhtt commented 1 week ago

I guess this is not needed anymore as you found a workaround to using branch https://github.com/flathub/org.subsurface_divelog.Subsurface/blob/a3498c27a33c08cb92fa69ac7ae2c165289feb10/org.subsurface_divelog.Subsurface.yaml#L208-L213 but I'd still move it to once per week using a custom workflow.

We plan to deal with these applications doing daily builds later on - by moving them to weekly/bi-weekly etc..