search

flathub-infra / flatpak-builder-lint

A linter for flatpak-builder manifests
MIT License
46 stars 113 forks source link

exceptions: allow automerge for com.fightcade.Fightcade #411

Closed Pobega closed 2 weeks ago

Pobega commented 2 weeks ago

The Fightcade client needs to be in sync with the current server version to function. If an update causes breakages the end result is identical to having an outdated Flatpak (the client will not work in either case.)

Allow Flathubbot automerging to keep the client in sync even when a developer with merge access is unavailable.

Pobega commented 2 weeks ago

Note: automerge was removed from the repo in https://github.com/flathub/com.fightcade.Fightcade/commit/71fb933f68e3ff0c6f36656d10275c75eb46d76c to facilitate a Fightcade update (since it was blocking all pull requests due to the linter), but I would preferably like to restore that if an exception is granted.

bbhtt commented 2 weeks ago

The Fightcade client needs to be in sync with the current server version to function. I

Do you have a source for this? FAQ or bug reports etc. when it goes out of sync

bbhtt commented 2 weeks ago

If you don't have it's fine, I can merge this on the basis of the description.

Pobega commented 2 weeks ago

Do you have a source for this? FAQ or bug reports etc. when it goes out of sync

It's the same as the other exception. Fightcade is a service that allows people to play with each other, once your client is out of sync (e.g. a new Fightcade releases, which is what we use the flathubbot PRs for) you will get an error like this (see attached image)

I don't believe there's an official explanation of this, besides a tiny portion towards the bottom of the FAQ at https://www.fightcade.com/faq

image

bbhtt commented 2 weeks ago

Thanks.

bbhtt commented 2 weeks ago

It should be up in some time https://docs.flathub.org/docs/for-app-authors/linter#check-currently-published-exceptions

Pobega commented 2 weeks ago

Thanks. Most bug reports for this client come through the Fightcade Discord, which tends to be a black hole for actually sourcing any issues. I'd prefer if people used the Github issue tracker, but it is what it is.