flathub-infra / flatpak-builder-lint

A linter for flatpak-builder manifests
MIT License
46 stars 113 forks source link

screenshots: Simplify screenshot checks #413

Closed bbhtt closed 1 week ago

bbhtt commented 1 week ago

"appstream-missing-screenshots" is now assigned to actually missing the screenshots/screenshot/image tag from catalogue. It was previously assigned to missing thumnailed screenshots from catalogue.

Checking for thumnails is not a good metric as appstream won't generate thumnails on low image dimensions. See https://github.com/flathub/org.kde.kruler/pull/31

Since all image types (source and thumbnails) are now correctly mirrored by libappstream, we can change "appstream-external-screenshot-url" to check if at least one screenshot of any type is mirrored to https://dl.flathub.org/media or https://dl.flathub.org/repo/screenshots

This removes a hard dependency on thumbnailed screenshots while keeping checks for having screenshot tags and at least one mirrored screenshot of any type.