flathub-infra / flatpak-builder-lint

A linter for flatpak-builder manifests
MIT License
46 stars 111 forks source link

Promote finish-args-contains-both-x11-and-wayland to error #414

Closed bbhtt closed 1 day ago

bbhtt commented 1 week ago

We deny it in moderation review anyway.

Needs a list and exceptions as some apps legitimately need it sometimes.

bbhtt commented 1 week ago

List of apps with both present (~293~ 285):

app.rednotebook.RedNotebook
ar.com.tuxguitar.TuxGuitar
at.priv.toastfreeware.ConfClerk
ca._0ldsk00l.Nestopia
ca.parallel_launcher.ParallelLauncher
cc.retroshare.retroshare-gui
chat.quadrix.Quadrix
chat.rocket.RocketChat
chat.schildi.desktop
ch.openboard.OpenBoard
com.abagames.rRootage
com.adamcake.Bolt
com.avocode.Avocode
com.bitwarden.desktop
com.bixense.PasswordCalculator
com.bladecoder.adventure-editor
com.brave.Browser
com.chez.GrafX2
com.dec05eba.gpu_screen_recorder
com.freerdp.FreeRDP
com.fribbledom.telephant
com.getmailspring.Mailspring
com.github._4lex4.ScanTailor-Advanced
com.github.artemanufrij.graphui
com.github.artemanufrij.playmymusic
com.github.artemanufrij.regextester
com.github.babluboy.bookworm
com.github.Bleuzen.FFaudioConverter
com.github.calo001.fondo
com.github.coslyk.MoonPlayer
com.github.dahenson.agenda
com.github.donadigo.appeditor
com.github.gijsgoudzwaard.image-optimizer
com.github.gyunaev.spivak
com.github.hluk.copyq
com.github.IsmaelMartinez.teams_for_linux
com.github.maoschanz.DynamicWallpaperEditor
com.github.marktext.marktext
com.github.Matoking.protontricks
com.github.mtkennerly.ludusavi
com.github.muriloventuroso.easyssh
com.github.naaando.lyrics
com.github.nrittsti.NTag
com.github.philip_scott.notes-up
com.github.philip_scott.spice-up
com.github.quaternion
com.github.Qv2ray
com.github.raibtoffoletto.litteris
com.github.robertsanseries.ciano
com.github.wwmm.pulseeffects
com.gitlab.librebob.Athenaeum
com.google.Chrome
com.google.ChromeDev
com.heroicgameslauncher.hgl
com.jetbrains.CLion
com.jetbrains.DataGrip
com.jetbrains.IntelliJ-IDEA-Community
com.jetbrains.IntelliJ-IDEA-Ultimate
com.jetbrains.WebStorm
com.katawa_shoujo.KatawaShoujo
com.lettier.movie-monad
com.locomalito.abbayedesmorts
com.logseq.Logseq
com.lunarclient.LunarClient
com.mastermindzh.tidal-hifi
com.mattermost.Desktop
com.microsoft.Edge
com.microsoft.EdgeDev
com.milesalan.mepo
com.modrinth.ModrinthApp
com.mousepawmedia.omission
com.notesnook.Notesnook
com.obsproject.Studio
com.opera.Opera
com.play0ad.zeroad
com.pot_app.pot
com.prusa3d.PrusaSlicer
com.revolutionarygamesstudio.ThriveLauncher
com.shatteredpixel.shatteredpixeldungeon
com.slugchess.SlugChess
com.sublimetext.three
com.supermodel3.Supermodel
com.syntevo.SmartGit
com.syntevo.SmartSynchronize
com.ticktick.TickTick
com.tutanota.Tutanota
com.ultimaker.cura
com.uploadedlobster.peek
com.usebottles.bottles
com.valvesoftware.Steam
com.viber.Viber
com.visualstudio.code-oss
com.vivaldi.Vivaldi
com.wire.WireDesktop
com.wiz.Note
com.xnview.XnViewMP
de.akaflieg_freiburg.cavok.add_hours_and_minutes
de.flinkebits.AvaEmailArchivar
de.klayout.KLayout
de.unifreiburg.ellipticcurve
dev.storyapps.starc
de.willuhn.Jameica
edu.stanford.Almond
eu.ototu.Quteqoin
eu.planete_kraus.Tarot
fr.fgrabenstaetter.DigitalAssets
ga.rpmtw.rpmlauncher
im.kaidan.kaidan
im.nheko.Nheko
im.riot.Riot
im.srain.Srain
in.cinny.Cinny
info.bibletime.BibleTime
in.srev.guiscrcpy
io.gdevelop.ide
io.github.aggalex.Wineglass
io.github.cges30901.hmtimer
io.github.cloose.CuteMarkEd
io.github.dbchoco.Salawat
io.github.dweymouth.supersonic
io.github.gerryferdinandus.bittorrent-tracker-editor
io.github.guillaumechereau.Goxel
io.github.hermitdemschoenenleben.linien
io.github.ja2_stracciatella.JA2-Stracciatella
io.github.jacalz.rymdport
io.github.janbar.noson
io.github.maddecoder.Classic-RBDOOM-3-BFG
io.github.mki1967.mki3dgame
io.github.mmstick.FontFinder
io.github.pd_l2ork.Pd_L2Ork
io.github.qnapi
io.github.rinigus.OSMScoutServer
io.github.rinigus.PureMaps
io.github.sharkwouter.Minigalaxy
io.github.slgobinath.SafeEyes
io.github.technic.e2designer
io.github.trigg.discover_overlay
io.github.ungoogled_software.ungoogled_chromium
io.gitlab.o20.word
io.gitlab.Turtlico
io.howl.Editor
io.itch.doctorm64.skippybot
io.itch.itch
io.jamulus.Jamulus
io.kinvolk.Headlamp
io.lbry.lbry-app
io.liri.Calculator
io.liri.Text
io.mpv.Mpv
io.otsaloma.gaupol
io.otsaloma.nfoview
io.qt.QtCreator
io.typora.Typora
jp.yvt.OpenSpades
net.bartkessels.getit
net.codeindustry.MasterPDFEditor
net.davidotek.pupgui2
net.devolutions.RDM
net.displaycal.DisplayCAL
net.hovancik.Stretchly
net.lutris.Lutris
net.mediaarea.AVIMetaEdit
net.mediaarea.BWFMetaEdit
net.mediaarea.DVAnalyzer
net.mediaarea.MediaConch
net.mediaarea.MediaInfo
net.mediaarea.MOVMetaEdit
net.mediaarea.QCTools
net.meshlab.MeshLab
net.mullvad.MullvadBrowser
net.oz9aec.Gpredict
net.pioneerspacesim.Pioneer
net.retrodeck.retrodeck
net.rpdev.OpenTodoList
net.sf.nootka
net.sourceforge.dmidiplayer
net.sourceforge.kmetronome
net.sourceforge.kmidimon
net.sourceforge.Lifeograph
net.studio08.xbplay
net.unvanquished.Unvanquished
net.wz2100.wz2100
nl.openoffice.bluefish
nz.mega.MEGAsync
one.ablaze.floorp
org.b3log.siyuan
org.bitbucket.mystery_keeper.VapourSynthEditor
org.bunkus.mkvtoolnix-gui
org.chromium.Chromium
org.claws_mail.Claws-Mail
org.codeblocks.codeblocks
org.dust3d.dust3d
org.eu.encom.spectral
org.fdroid.Repomaker
org.ferdium.Ferdium
org.flameshot.Flameshot
org.free_astro.siril
org.freedesktop.adriconf
org.freedesktop.Piper
org.freedesktop.Tuhi
org.freeplane.App
org.frescobaldi.Frescobaldi
org.fritzing.Fritzing
org.gabmus.unifydmin
org.geeqie.Geeqie
org.geogebra.GeoGebra
org.getmonero.Monero
org.gnome.Eolie
org.gnome.Games
org.gnome.Genius
org.gnome.Keysign
org.gnome.OCRFeeder
org.gnome.OfficeRunner
org.gnome.Tau
org.hedgewars.Hedgewars
org.homelinuxserver.vance.biblereader
org.inkscape.Inkscape
org.jaspstats.JASP
org.karapulse.Karapulse
org.kde.kamoso
org.kde.kig
org.kde.ktouch
org.kde.kxstitch
org.kde.marble
org.kde.skrooge
org.keepassxc.KeePassXC
org.KekikAkademi.BTKSorgu
org.kiwix.desktop
org.librepcb.LibrePCB
org.mamedev.MAME
org.mobsya.ThymioSuite
org.mozilla.Thunderbird
org.msweet.htmldoc
org.munadi.Munadi
org.musicbrainz.Picard
org.octave.Octave
org.olivevideoeditor.Olive
org.onlyoffice.desktopeditors
org.openchemistry.Avogadro2
org.openkj.OpenKJ
org.openmsx.openMSX
org.pjbroad.EternallandsClient
org.polymc.PolyMC
org.ppsspp.PPSSPP
org.prismlauncher.PrismLauncher
org.pyzo.pyzo
org.qgis.qgis
org.quetoo.Quetoo
org.raceintospace.Raceintospace
org.robocode.Robocode
org.sauerbraten.Sauerbraten
org.scummvm.ScummVM
org.shadowsocks.qt5client
org.signal.Signal
org.sparkleshare.SparkleShare
org.speedcrunch.SpeedCrunch
org.synfig.SynfigStudio
org.tropy.Tropy
org.tug.texworks
org.tuxemon.Tuxemon
org.tuxpaint.Tuxpaint
org.vinegarhq.Vinegar
org.vranki.spectral
org.winehq.Wine
org.zim_wiki.Zim
org.zrythm.Zrythm
org.zulip.Zulip
page.codeberg.JakobDev.jdMinecraftLauncher
page.codeberg.lazyt.ubpm
party.supertux.supertuxparty
ru.linux_gaming.PortProton
sa.sy.bluerecorder
sh.cider.Cider
sh.fhs.KatawaShoujoReEngineered
space.fips.Fips
studio.kx.carla
tv.plex.PlexHTPC
ua.org.brezblock.q4wine
uk.jnthn.backgammony
uk.me.doof.Lander
us.zoom.Zoom
website.i2pd.i2pd
xyz.hyperplay.HyperPlay
xyz.splashmapper.Splash
xyz.stuerz.BilligSweeper

Direct uploads:

org.mozilla.Thunderbird
com.obsproject.Studio
hfiguiere commented 1 week ago

For org.inkscape.Inkscape it is because there are extension that use Tk as their UI and therefor X11 must be available for them. Much like Scribus that is not on the list.

hfiguiere commented 1 week ago

And for net.displaycal.DisplayCAL, the nature of the application is that it needs both two. Some utilities need X11.

hfiguiere commented 1 week ago

For com.github._4lex4.ScanTailor-Advanced I believe it should be X11 only as Qt wayland support is buggy.

travier commented 1 week ago

KDE side of things tracked in https://invent.kde.org/teams/flathub/issues/-/issues/30.