search

flathub-infra / flatpak-builder-lint

A linter for flatpak-builder manifests
MIT License
46 stars 113 forks source link

Update exceptions.json #420

Closed yairm210 closed 6 days ago

yairm210 commented 6 days ago

Added automerge exception for Unciv - averages to 2 releases a week

Unciv itself is build in a Github Actions pipeline - if you would rather I use the Github action for flatpak releases I could do that, not sure if there are problems in "transferring" from the bot to the github action

bbhtt commented 6 days ago

What's blocking you from manually merging the two PRs?

yairm210 commented 6 days ago

I have 8 different distribution paths for my app, I don't have time or attention for manual work per release If your new policy is that everything requires manual approval, that's also a valid answer, and I'll remove this app from Flathub entirely (Not in like a bad threatening way, just practical considerations, don't mean to come off as rude, but I'd rather not have outdated versions lying around where people will use them and complain about ancient irrelevant problems)

bbhtt commented 6 days ago

That was always the policy - the status checks, not pushing directly to main etc was for that. It just wasn't enforced and automerge allowed a way out. Automerge was introduced only for extra-data sources, but started being used as an all purpose automation.

Without a proper reason I can't really allow this exception, then pretty much everyone will say the same thing to get it.

yairm210 commented 6 days ago

OK, no problem, got it 👍🏿 If I use the Github action, can that lead to a touchless deploy? Or would that require manual intervention as well?

bbhtt commented 6 days ago

You can't really upload to Flathub with github-actions, direct-upload is only available to a few trusted publishers like Mozilla etc. and it is unclear at the moment if it will be made available to everyone.

You can however host your own Flatpak repo, I have a bunch of examples here https://docs.flatpak.org/en/latest/hosting-a-repository.html#hosting-a-repository-on-gitlab-github-pages

yairm210 commented 6 days ago

Thanks for your help!