search

flathub-infra / flatpak-builder-lint

A linter for flatpak-builder manifests
MIT License
48 stars 125 forks source link

Auto-merging org.qownnotes.QOwnNotes #428

Closed pbek closed 1 month ago

pbek commented 1 month ago

Is there a way to get an exemption for org.qownnotes.QOwnNotes to be auto-merged? All releases are tested upstream and there are no other dependencies which can break something when updated. 🙏🏻

bbhtt commented 1 month ago

The way to get it would be to have a proper reason. What exactly is preventing merging the updates manually?

It's also not getting a huge number of releases, I only see 2-3 releases per month

All releases are tested upstream and there are no other dependencies which can break something when updated.

Are you testing it in the Flatpak environment upstream? "No other dependencies" does not seem correct, the main binary is using 41 libraries from runtime. The runtime has its own API/ABI different from distributions

pbek commented 1 month ago

@Erick555, is there even any manual testing going on? 😊

Erick555 commented 1 month ago

"No other dependencies" does not seem correct, the main binary is using 41 libraries from runtime. The runtime has its own API/ABI different from distributions

I meant no dependencies shipped in app (except git used as cli tool). Runtime API/ABI is supposed to be stable otherwise it's bug.

In general auto-merged update is as tested as manual update except developer must go to flathub and click the button all the time. There is no benefit for flathub and users will get updates with some delay.

bbhtt commented 2 weeks ago

We decided to allow newly verified applications access to automerge, I have added the exception in https://github.com/flathub-infra/flatpak-builder-lint/pull/458

pbek commented 2 weeks ago

Hey, thank you very much!

Erick555 commented 2 weeks ago

@pbek you need to revert https://github.com/flathub/org.qownnotes.QOwnNotes/commit/ac553fe7d54e40429633a9cc1c232a2d4ea4ada8 to re-enable auto-merging

pbek commented 2 weeks ago

I thought as much. 😉 Doing https://github.com/flathub/org.qownnotes.QOwnNotes/pull/284 now...