search

flathub-infra / flatpak-builder-lint

A linter for flatpak-builder manifests
MIT License
48 stars 125 forks source link

Add exceptions for "finish-args-contains-both-x11-and-wayland" for org.godotengine.Godot and org.godotengine.GodotSharp #433

Closed Zishan-Rahman closed 1 month ago

Zishan-Rahman commented 1 month ago

Currently, the beta branch for org.godotengine.Godot (Godot 4, that is) has access to both the X11 and Wayland sockets, as denoted in finish-args. This was introduced in https://github.com/flathub/org.godotengine.Godot/commit/673564087d94ab47611628d731cf55f617b6406d from @wjt's now merged PR https://github.com/flathub/org.godotengine.Godot/pull/170 (sorry for the ping). Usually, we would use --socket=fallback=x11, but in this case, without direct access to both sockets, Godot will not open on Wayland sessions, as X11 is still very much the default.

I expect the changes added to the beta branch from https://github.com/flathub/org.godotengine.Godot/pull/170 to be added to both the stable Godot Flatpak and the stable GodotSharp Flatpak (which, as of this moment, doesn't yet have a beta branch) when Godot 4.3 gets a stable release, hence why I preliminarily added the exception to org.godotengine.GodotSharp as well as org.godotengine.Godot.

Once this PR is merged, I'll be able to rebuild the test build in https://github.com/flathub/org.godotengine.Godot/pull/175, which should hopefully succeed without any further issues.