search

flathub-infra / flatpak-external-data-checker

A tool for checking if the external data used in Flatpak manifests is still up to date
GNU General Public License v2.0
115 stars 36 forks source link

Sourceforge round-robin servers create flood of updates #150

Closed hadess closed 3 years ago

hadess commented 3 years ago

The flathubbot that runs flatpak-external-data-checker created a flood of updates from version 6.5 to version 6.5 for Sweethome3D, while pointing to a slightly different tarball host each time.

These are the PRs created: https://github.com/flathub/com.sweethome3d.Sweethome3d/pulls?q=is%3Apr+%226.5%22

And this is the x-checker-data field: https://github.com/flathub/com.sweethome3d.Sweethome3d/blob/ee6fd8e4d491ebcbf11705b4b5b7589d0c9d3faf/com.sweethome3d.Sweethome3d.json#L38-L45

gasinvein commented 3 years ago

This can be fixed as easily as by disabling follow_redirects for HTMLChecker (and returning original url instead of real), but I'm not sure if there are no apps relying on current (IMO wrong) behavior. Ping @wjt @andrunko

hadess commented 3 years ago

https://github.com/flathub/flatpak-external-data-checker/pull/151 maybe?

wjt commented 3 years ago

I don't remember it being deliberate that HTMLChecker followed redirects. I know some of the others do follow redirects by design (specifically the rotating URL checker – that's its whole purpose).