search

flathub-infra / flatpak-external-data-checker

A tool for checking if the external data used in Flatpak manifests is still up to date
GNU General Public License v2.0
115 stars 36 forks source link

Multiple (almost) identical pull requests #322

Open nicolasfella opened 2 years ago

nicolasfella commented 2 years ago

Today https://github.com/flathub/org.kde.itinerary got 6 pull requests containing almost the same changes (sometimes 7 modules are updated, sometimes 8)

There should only be one PR containing all changes, or multiple with one updated module each

gasinvein commented 2 years ago

Looks like the same problem as #315 - version fluctuations across download.kde.org mirrors.

johanfleury commented 2 years ago

Same issue on flathub/com.jetbrains.PyCharm-Professional. I’m not even reading those PRs anymore.

Honestly I’m wondering if this external-data-checker is the correct approach. There are many great FLOSS tools that do version checking (renovate is a good example), why not build upon it?

gasinvein commented 2 years ago

I’m not even reading those PRs anymore.

Why then even configure x-checker-data for dozens of dependencies if you never intended to review and/or update at least some of them?

johanfleury commented 2 years ago

It was a contributor who did that (I’m barely maintaining this package) and I believe having automatic updates is a good think. I just don’t think I should receive 3 PR a day for the exact same thing.

gasinvein commented 2 years ago

tl; dr remove x-checker-data entries from PyPI sources.

I just don’t think I should receive 3 PR a day for the exact same thing.

It's not the same thing. Each PR has slightly different packages updated to different versions. If you've merged e.g. this one a month ago, then the set of updated packages would be much smaller and the difference between changes would be more clear.

I believe having automatic updates is a good think

Flatpak-builder manifests don't have any kind of technical relation between source items whatsoever, and f-e-d-c can't can ensure consistent dependencies and buildable updates for you, not in a universal way at least. So no, dumping lots of x-checker-data stanzas to almost every source is not a good idea at all.

It was a contributor who did that

And they didn't do any favour to neither you nor me.