search

flathub-infra / flatpak-external-data-checker

A tool for checking if the external data used in Flatpak manifests is still up to date
GNU General Public License v2.0
115 stars 34 forks source link

flathubbot spams PR requests for the same update #400

Closed ghisvail closed 10 months ago

ghisvail commented 10 months ago

One a day for the last 2 weeks here.

The release monitoring pattern should also be updated to discard the rpios suffix on the version tag.

Nonetheless, only a single PR should have been opened by the bot.

wjt commented 10 months ago

If you look closely the PR is different every day: it uses today's date for the release date.

This is because release-monitoring/anitya's API doesn't give us a release date, and https://github.com/raspberrypi/rpi-imager/archive/refs/tags/v1.8.3_rpios.tar.gz does not have a Last-Modified, so we use the Date header, which is always today's date.

I'll send you a PR to use a different checker.

wjt commented 10 months ago

The reason the date being different every day matters is that the name of the branch in the PR is derived from the contents of the Git tree, which is how the checker avoids opening multiple identical PRs. It keeps no state. I am beginning to doubt this design but that's how it works today.