flathub-infra / flatpak-external-data-checker

A tool for checking if the external data used in Flatpak manifests is still up to date
GNU General Public License v2.0
116 stars 34 forks source link

automerge-flathubbot-prs leaves stale PRs if there's an update more than once per hour #411

Open dginovker opened 5 months ago

dginovker commented 5 months ago

image

Screenshot taken from here: https://github.com/flathub/vet.rsc.OpenRSC.Launcher/pulls

Basically, here's what happened:

Time Event
00:30 Upstream updated OpenRSC.jar
01:00 flathubbot opened a new PR for the update
01:30 Upstream updated OpenRSC.jar again
02:00 flathubbot opened a PR for the update (again)
02:30 Upstream updated OpenRSC.jar a third time
03:00 flathubbot opened a PR for the third time
04:00 flathubbot merged the third PR

However, the 1st and 2nd (now with a merge conflict) are now sitting there stale.

Possible solutions:

wjt commented 5 months ago

I can see why this is annoying, but it looks like you are not tracking releases of OpenRSC.jar, but builds from the development branch. That's really not what this tool was designed for.