Don't clear environment variables

flathub-infra / flatpak-external-data-checker

A tool for checking if the external data used in Flatpak manifests is still up to date

GNU General Public License v2.0

116 stars 34 forks source link

Don't clear environment variables #414

Closed dbnicholson closed 2 months ago

dbnicholson commented 2 months ago

See the first commit for discussion, but basically it can't be done correctly like this and it was causing the GIT_AUTHOR_* environment variables to be unset when making commits. A couple tests are added to make sure that doesn't happen again.

Fixes: #413

dbnicholson commented 2 months ago

LGTM – presumably if you rebase the test failures will disappear since your branch at #415 was merged?

It should. Rebased now.

dbnicholson commented 2 months ago

LGTM – presumably if you rebase the test failures will disappear since your branch at #415 was merged?

It should. Rebased now.

And yet flake8 has done its job and found and unused import.