search

flathub-infra / flatpak-external-data-checker

A tool for checking if the external data used in Flatpak manifests is still up to date
GNU General Public License v2.0
116 stars 34 forks source link

I found why the external data checker fails on github actions, I figured out the solution #418

Closed tobiasmicheler closed 2 months ago

tobiasmicheler commented 2 months ago

When an app uses git as the source, and uses a tag pattern that fails this assert: https://github.com/flathub-infra/flatpak-external-data-checker/blob/6ab69bcbcc35507104198c17895d36b4113f204a/src/checkers/gitchecker.py#L101 , such as this app currently: https://github.com/flathub/com.modrinth.ModrinthApp/blob/1d954cc7c91841d020fe4c860593789a16ca62c6/com.modrinth.ModrinthApp.yml#L108 , the external data checker should skip this app entirely. If the checker is run from the source code directly, this works. However, if the checker is run from the Flatpak or the docker container the checker stalls for the rest of the run. On GitHub actions it is getting cancelled by GitHub after 6 hours. I have submitted a pull request to the offending app to fix the regex, but it seems this part of the external-data-checker should be fixed. I am not sure how though.

tobiasmicheler commented 2 months ago

actually, I figured it out: https://github.com/flathub-infra/flatpak-external-data-checker/pull/419